Revert "Keep null value" #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit abecffc.
|
Thank you! I'm going to treat this as a bug fix, and release it under the current major version. |
|
Does it mean that a new major version will be created that keeps the null values ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 👋
This PR reverts the changes made in the original PR. Even though I am a proponent of the suggested changes, unfortunately it's a breaking change for people who don't make use of type juggling through the use of
declare(strict_types=1).Moreover, this is also going to break the code of those who are on the most recent PHP versions where
str_*functions no longer acceptnullas a legitimate value.The suggested changes should be targeted at a
v7or anextbranch, ideally.Thank you 🙏